Code Smell

A code smell is a symptom in code that indicates potential design flaws or bad practices.

Explanation:

  • Code smells donโ€™t break the system but reduce maintainability.
  • Examples:
    • Duplicate code โ€“ Same logic repeated in multiple places.
    • Long methods โ€“ Methods that do too much and become unreadable.
    • Magic numbers โ€“ Hardcoded values with no explanation.

Example (Bad Code – Code Smell)

java int calc(int a, int b) {
return a * b * 3.14; // Magic number (3.14 should be a constant)
}

Fix (Refactored Code):

javafinal double PI = 3.14;
int calc(int a, int b) {
return a * b * PI;
}
  • The PI value is now readable and reusable.